Replace std::ostringstream usage with fmt::format #11972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minty-Meeo
force-pushed
the
string-improvements-part-1c
branch
from
a094233
to
664a6af
Compare
Source/Core/UICommon/UICommon.cpp
Outdated
Comment on lines
556
to
557
| return fmt::format("{:.{}f} {}", bytes / unit_size, decimals, | ||
| Common::GetStringT(unit_symbols[unit])); |
There was a problem hiding this comment.
This needs to be {:.{}Lf} {} to be equivalent since this previously respected the user's locale for the decimal separator.
|
Apart from that locale thing this looks good to me. |
|
I just noticed Joystick::Hat::GetName() is also doing some funky stuff with a char[] buffer that could possibly be simplified with fmt::format. Might I tack it onto this PR? |
|
lol yeah that's very funky. Sure. Is that even threadsafe? Does that produce a copy of the string? |
Minty-Meeo
force-pushed
the
string-improvements-part-1c
branch
from
664a6af
to
ffabb6c
Compare
|
My intuition tells me that it copies the string from rodata into the stack since it's not static. |
AdmiralCurtiss
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part C of splitting #11913