Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DITConfiguration: Use File::ReadFileToString #11973

Merged
merged 1 commit into from Jun 18, 2023
Merged

DITConfiguration: Use File::ReadFileToString #11973

merged 1 commit into from Jun 18, 2023

Conversation

Minty-Meeo
Copy link
Contributor

Part D of splitting #11913

@Minty-Meeo Minty-Meeo marked this pull request as ready for review June 18, 2023 02:28
JosJuice
JosJuice approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We shouldn't use raw file streams (without OpenFStream) anywhere, due to Windows not handling path encodings the way we want.

iwubcode
iwubcode approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always meant to fix this. Thanks! LGTM

@JosJuice JosJuice merged commit 9943750 into dolphin-emu:master Jun 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice approved these changes

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Minty-Meeo @JosJuice @iwubcode