Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Handle game shutdown in onTitleChanged #11989

Merged
merged 1 commit into from Jun 28, 2023
Merged

Android: Handle game shutdown in onTitleChanged #11989

merged 1 commit into from Jun 28, 2023

Conversation

JosJuice
Copy link
Member

No description provided.

@JosJuice JosJuice marked this pull request as ready for review June 23, 2023 18:40
@JosJuice JosJuice requested a review from t895 June 27, 2023 21:12
@t895
Copy link
Contributor

t895 commented Jun 28, 2023

This seems perfectly fine but why update the input overlay in the try/catch block? It's already null safe so you could just run it outside.

@JosJuice
Copy link
Member Author

refreshInputOverlay indirectly calls IsEmulatingWii, which just like GetCurrentTitleDescription calls CheckGameMetadataValid. CheckGameMetadataValid is what's throwing the exceptions.

@t895 t895 merged commit e185dbf into dolphin-emu:master Jun 28, 2023
14 checks passed
@JosJuice JosJuice deleted the android-title-on-shutdown branch June 28, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t895 t895 t895 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@JosJuice @t895