Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DolphinQt: Add i18n comments for Skylanders strings #11994

Merged
merged 1 commit into from Jun 27, 2023
Merged

DolphinQt: Add i18n comments for Skylanders strings #11994

merged 1 commit into from Jun 27, 2023

Conversation

JosJuice
Copy link
Member

Also changed the spelling of "Superchargers" to "SuperChargers".

@SuperSamus
Copy link
Contributor

The Wii (and 3DS) versions of "Skylanders: SuperChargers" are titled "Skylanders: SuperChargers Racing". It's a completely different game (though it uses the same figures).

@JosJuice
Copy link
Member Author

Are you suggesting that I change this comment? The game "Skylanders: SuperChargers". The game's title is the same in every country it was released in. It was not released in Japan.

@SuperSamus
Copy link
Contributor

SuperSamus commented Jun 25, 2023 •
edited

I was thinking about that comment, yes.
I don't know if it should be changed, it was just an FYI.

@JosJuice
DolphinQt: Add i18n comments for Skylanders strings
09f8f29 
Also changed the spelling of "Superchargers" to "SuperChargers".
@JosJuice JosJuice merged commit 766b860 into dolphin-emu:master Jun 27, 2023
14 checks passed
@JosJuice JosJuice deleted the skylanders-i18n branch June 27, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@JosJuice @SuperSamus