EXI: Remove pointless PauseAndLock functions #11996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ExpansionInterfaceManager::PauseAndLock function does nothing but call other functions that have no effect. ExpansionInterfaceManager::PauseAndLock calls CEXIChannel::PauseAndLock, which in turn calls IEXIDevice::PauseAndLock. None of the classes deriving from IEXIDevice override PauseAndLock, and the implementation in IEXIDevice does nothing.
|
I agree that this looks pretty pointless at the moment. I've been trying to trace this back in the history to a point where it actually had anything, and I only found something in the Memory Card class, which was removed in bd7f856. So this is probably fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ExpansionInterfaceManager::PauseAndLock function does nothing but call other functions that have no effect.
ExpansionInterfaceManager::PauseAndLock calls CEXIChannel::PauseAndLock, which in turn calls IEXIDevice::PauseAndLock. None of the classes deriving from IEXIDevice override PauseAndLock, and the implementation in IEXIDevice does nothing.