Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Fix some Post Process Configuration Widget issues #3-4 #12001

Merged
merged 1 commit into from Jun 30, 2023

Conversation

Filoppi
Copy link
Contributor

@Filoppi Filoppi commented Jun 27, 2023

1 ) When first opened, the (user selected) post process shader config widget would print the wrong values on the text label next to int range sliders. For example if the range was from 1 to 6, and the value loaded from the config was 1, the label would print 0 when first opened, to then start showing the correct value once the slider was first moved.

This mirrors the behaviour of the float slider code below:
auto* const value_box = new QLineEdit(QString::asprintf("%f", m_config_option->m_float_values[i]));

2 ) The defautl int slider value would also be set wrong on first load, as it was being divided by the slider max instead of the slider step amount (again, just like for the float implementation). This is a mistake I had made with my previous submission.

@Filoppi Filoppi changed the title Qt: Fix some Post Process Configuration Widget issues #3 Qt: Fix some Post Process Configuration Widget issues #3-4 Jun 27, 2023
@AdmiralCurtiss
Copy link
Contributor

Please remove the # from your commit messages, GitHub assumes they're references to PR numbers which is very confusing.

1 ) When first opened, the (user selected) post process shader config widget would print the wrong values on the text label next to int range sliders. For example if the range was from 1 to 6, and the value loaded from the config was 1, the label would print 0 when first opened, to then start showing the correct value once the slider was first moved.

This mirrors the behaviour of the float slider code below:
```auto* const value_box = new QLineEdit(QString::asprintf("%f", m_config_option->m_float_values[i]));```

2 ) The defautl int slider value would also be set wrong on first load, as it was being divided by the slider max instead of the slider step amount (again, just like for the float implementation). This is a mistake I had made with my previous submission.
@AdmiralCurtiss AdmiralCurtiss merged commit 94f3426 into dolphin-emu:master Jun 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants