VideoCommon: add a pixel shader asset #12009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an asset that describes a pixel shader. I've based my design somewhat off of Unity game engine but I believe other modern graphics renders follow something somewhat similar.
This shader asset contains the shader code for the shader itself, as well as a description of the inputs which match what we want to expose from the shader code. The inputs are just the type (and eventually the default data value), not the actual data that is being held. This makes these assets highly reusable. At the moment, I've only exposed a 2D texture sampler type. But in the future there will be uniform support for colors/integers/etc and likely will also include inputs for cube-maps, 3d textures, and named render targets.
With the data type defined, where does the actual data come from? That is the job of the material asset. That is coming in a subsequent review.
I will be using this in a series of future reviews.