GekkoDisassembler: Remove unused member and parameters #12019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Jul 2, 2023
Dentomologist
commented
Jul 2, 2023
Comment on lines
-1992
to
+1949
| nooper(in, "eieio", PPCF_SUPER); | ||
| nooper(in, "eieio"); |
There was a problem hiding this comment.
Today I learn about Old MacDonald's favorite instruction.
|
If you want to remove this, you should probably also remove the now unused Flags enum in GekkoDisassembler.h. |
|
PPCF_64 is still used by trap and trapi. Should I leave the enum alone for context or remove it and convert PPCF_64 to a constant? |
|
Ah, I missed that. I suppose we can leave it then. |
|
This needs a rebase. |
Writes to m_flags are pointless as it's never read.
With the removal of m_flags, dmode is no longer used in nooper.
With the removal of m_flags, dmode is no longer used in dab.
With the removal of m_flags, dmode is no longer used in rrn.
With the removal of m_flags, dmode is no longer used in ldst.
With the removal of m_flags, dmode is no longer used in fdabc.
Dentomologist
force-pushed
the
gekkodisassembler_remove_unused_member_and_parameter
branch
from
22d4132
to
3c6ea82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GekkoDisassember.m_flags is written to but never read, so it can be removed.
With the removal of m_flags the dmode parameter is no longer used in functions nooper, dab, rrn, ldst, and fdabc, so remove it from them.