VideoCommon: add material asset #12024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/Core/VideoCommon/Assets/DirectFilesystemAssetLibrary.cpp
Outdated
Show resolved
Hide resolved
…ics engines where it provides data to be used in conjunction with a shader asset to generate a runtime AbstractShader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of my asset reviews (for now!). This adds a material asset for pixel shaders. As I mentioned in my shader asset review, a material provides the data for a shader. Any shader input values will be in the material asset. This makes shaders reusable. Ex: you can have a single shader that might draw an outline around an object with an exposed color, one material that says to make the outline red and another that says to make the outline blue.
At the moment, materials are very simple. The only input is a named texture asset. In the future, materials will also handle other forms of data (color, integers, booleans, etc) that will be passed to the runtime shader as uniforms.
In the short term, this will be used by the revamped #11300 .