RetroAchievements - Rearranged startup process

[LillyJadeKatrin]

Moved AchievementManager Init further down in the MainWindow constructor; its original position was because it had an impact on the contents of the menu bar, and this is no longer the case. On top of this, if achievements are enabled and there's an API token already in the config (meaning the emulator will attempt to verify credentials and "log in"), it opens the Achievements dialog as a way of notifying the player that the achievements are active.

[AdmiralCurtiss]

I'm not sure how I feel about popping up an extra window when Dolphin is opened (even if it only happens if you've previously logged in), this seems like questionable UX. @MayImilae thoughts?

[LillyJadeKatrin]

If there's a way to pop up some kind of notification in the main Dolphin window, that would have been my first choice, but I wasn't able to find anything to support that when I looked and came up with this as an alternative. I'm very open to suggestions.

[MayImilae]

Well, if the popup occurred when achievements were disabled, it would be a hard nope. Even when it's only with rcheevos enabled that it occurs, a pop up is not great UX. So I don't think that UX is bad enough to refuse outright, but I'll discuss some alternatives.

So one way would be to tap into the notification systems of modern OSes. It's a lot of fuss to get permission to send notifications just for one thing, admittedly, but there other possible uses of the notification system. I'd personally love "logging enabled" and "logging disabled" notifications. I tend to leave logging on.

Another option is the shortcut bar. Something akin to this (but an actual icon and not a 5 second scribble):

So I have some conditions for this. It should not be present until a user turns on rcheevos for the first time. However, once they do, we can add this to the shortcut bar (and allow the user to add/remove it if they want to in the settings somewhere). Then, not only does it give a shortcut to achievements, but it also serves as an indicator as to whether it rcheevos are enabled or not, and even if it is hardcore or not. After all, swapping between images on the shortcut bar is pretty easy. ...probably. tbh I haven't done it myself but it should be easy.

But as long as it only appears for users that are using rcheevos, and users have control to hide it if they so wish, I'm ok with it taking a spot on our shortcut bar. We'll need input from other devs to see if they are also ok with that, but I think this is a better option than a popup for achievement users.

EDIT: Also I think it is kind of mandatory for an achievement shortcut item to be called rcheevos and not retroachievements. Not only is retroachievements way too close to the name of you know what to be front and center in our UI... but "retroachievements" the word is too long, it doesn't fit on our shortcuts bar. ┐(´-｀)┌

[LillyJadeKatrin]

Excellent discussion, and I like the menu bar idea. I'll spin that off into a separate PR and in the meanwhile trim this one down to just the initial bugfix move.