Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt: Color Correction window fixes #12033

Merged
merged 1 commit into from Jul 16, 2023
Merged

Qt: Color Correction window fixes #12033

merged 1 commit into from Jul 16, 2023

Conversation

mbc07
Copy link
Contributor

@mbc07 mbc07 commented Jul 5, 2023

This PR contains a collection of improvements and fixes for the Color Correction window, originally introduced in PR #11850:

  • Restored default padding around the widgets
  • Made the window resizable and made sure it doesn't fall apart during resizing
  • Trimmed/Removed unnecessary fractional part of float numbers where applicable (visual only, they still have the same precision code side)
  • Converted "SDR Display Gamma sRGB" checkbox and "SDR Display Custom Gamma" slider into a secondary group box with radio buttons to more explicitly show the relation between the two
  • Various tooltip fixes
    • Added missing title to "Game Gamma" tooltip and mentioned default value in the tooltip description
    • Added tooltip to "HDR Paper White Nits" slider
    • Removed unnecessary line breaks where applicable
    • Removed empty tooltip from "SDR Display Custom Gamma"
  • Fixed copyright date and include order on source files

image

image

image

Ready to review and merge.

@mbc07 mbc07 force-pushed the ColorCorrectionGUI_fixes branch from 3fc17ba to ae5ef9a Compare July 5, 2023 11:11
@mbc07
Copy link
Contributor Author

mbc07 commented Jul 10, 2023

Um... ping?

iwubcode
iwubcode approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Changes seem like good improvements. Minor testing.

@AdmiralCurtiss AdmiralCurtiss merged commit 2814e4e into dolphin-emu:master Jul 16, 2023
11 checks passed
@mbc07 mbc07 deleted the ColorCorrectionGUI_fixes branch July 16, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss left review comments

@JosJuice JosJuice JosJuice left review comments

@Dentomologist Dentomologist Dentomologist left review comments

@Filoppi Filoppi Filoppi approved these changes

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@mbc07 @AdmiralCurtiss @JosJuice @Filoppi @iwubcode @Dentomologist