Common: Add a strerror_r wrapper #12043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jul 12, 2023
Source/Core/Common/CommonFuncs.cpp
Outdated
| // There are two variants of strerror_r. The XSI version stores the message to the passed-in | ||
| // buffer and returns an int (0 on success). The GNU version returns a pointer to the message, | ||
| // which might have been stored in the passed-in buffer or might be a static string. | ||
|
|
||
| // We check defines in order to figure out variant is in use, and we store the returned value | ||
| // to a variable so that we'll get a compile-time check that our assumption was correct. |
There was a problem hiding this comment.
The part about storing the value in a variable to get a type check is no longer true. (For the GNU case, that is.)
There was a problem hiding this comment.
Right, I'll remove that part from the comment.
|
@sepalani It does fix the issue! |
|
Seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative approach to #12037 which tries to fix a compilation issue related to
strerror_r.@AnErrupTion
Does this approach fix your compilation issue on musl libc?
Ready to be reviewed & tested.