Skylanders: Update J command documentation #12051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be helpful to add a "Skylanders:" prefix (or similar) to the titles of the PR and the commit. |
mandar1jn
changed the title
|
will do |
mandar1jn
force-pushed
the
J-documentation-improvements
branch
from
73a5b6e
to
bf93e84
Compare
|
This should be ready for review |
|
!rebuild |
|
@dolphin-emu-bot rebuild |
|
Will squash in a few hours. |
I initially thought the 0x01 side was both sides (equavalent to just C. However, this turned out to be something I forgot I implemented in my personal interface. 0x01 does not seem to change any colors. Recently discovered how exactly the last 2 bytes of the J command for timing data
mandar1jn
force-pushed
the
J-documentation-improvements
branch
from
5439ef4
to
eba5291
Compare
|
Yay. Lint passes now and it's one commit. Really need to stop messing up rebase |
|
Is there anything blocking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially thought the 0x01 side was both sides (equavalent to just C. However, this turned out to be something I forgot I implemented in my personal interface. 0x01 does not seem to change any colors. Handling of 0x01 in SetLEDs maintained because it's still used for the implementation of the C command
Recently discovered how exactly the last 2 bytes of the J command for timing data.