Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enable WiiLink checkbox to Android GUI #12058

Merged
merged 1 commit into from Jul 22, 2023

Conversation

noahpistilli
Copy link
Member

Adds the Enable WiiConnect24 via WiiLink checkbox. Allows for the onboard WiiLink patches to function if enabled.

Copy link
Contributor

@t895 t895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now but in the future I'd like to see a way to open an intent to a browser for a link like that

@@ -469,6 +469,7 @@ enum class BooleanSetting(
"ButtonToggleNunchukStick",
true
),
MAIN_WII_WIILINK_ENABLE(Settings.FILE_DOLPHIN, Settings.SECTION_INI_CORE, "EnableWiiLink", false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort the settings in the same order as in the C++ code, so they're easier to keep track of. (MAIN_WII_WIILINK_ENABLE should be right below MAIN_ENABLE_SAVESTATES.)

@JosJuice JosJuice merged commit 3d9bc85 into dolphin-emu:master Jul 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants