cubeb: Change name to "Dolphin Emulator"

[SuperSamus]

To avoid conflicts with KDE's file manager.

Before:

After:

[cobalt2727]

does that bug only happen if the audio backend is Cubeb?

[SuperSamus]

Yes. It doesn't happen on Pulse or ALSA (checked on both versions).

[Naim2000]

Just set it to pulse, looks alright

[JMC47]

Pfft, we were Dolphin first. They should change their name to Dolphin Folder Manager!!!!

/s

In all seriousness this seems fine at a glance.

[sepalani]

I'm unfamiliar with this folder manager, what happen if you launch 2 Dolphin instances (i.e. a normal one and a portable one)? Are there two separate icons (since they're different apps) and if so, will this PR fix the bug?

[mbc07]

It's probably wise to add a comment in the code explaining why we're explicitly using full name to initialize Cubeb...

[SuperSamus]

if you launch 2 Dolphin instances

The instances are stacked in the task manager.

Screenshot taken with 3 Dolphins open (only one playing a game).

EDIT: If you separate the icons, only the ones playing a game show the audio icon.

[SuperSamus]

It's probably wise to add a comment in the code explaining why we're explicitly using full name to initialize Cubeb...

I don't think anyone looking at the code is going to wonder that?
And if they do, git blame exists.

[AdmiralCurtiss]

Yeah I don't think that's necessary...

sepalani makes a good point though. Should we maybe append the process ID or something so the individual instances can be differentiated? What exactly does this ID string do, anyway?

[SuperSamus]

What exactly does this ID string do, anyway?

It's the name shown when looking which applications are playing audio.

[cobalt2727]

In that case I would definitely agree that appending the process ID would be good, to make it easy to, say, turn the volume down on all but one of them.

(Maybe only append something if multiple instances are open? Is detecting that possible somehow?)

[JosJuice]

I think this change is fine as it is.

[SuperSamus]

In that case I would definitely agree that appending the process ID would be good, to make it easy to, say, turn the volume down on all but one of them.

You already can.

[SuperSamus]

Still, there is something weird going on KDE's side.

I tried having multiple instances of multiple applications, and playing audio on only one of them each.
In this image:

• The first mpv is playing music, the second is not.
• The first Dolphin Emulator instance is playing a game, and Dolphin file manager is "inheriting" the speaker icon (even though it's not even open).
• However, the second Dolphin Emulator instance is not playing any games, and it doesn't have the speaker icon (as it should).

I feel like I should report it.

EDIT: https://bugs.kde.org/show_bug.cgi?id=472539

[AdmiralCurtiss]

Well, if you figure out anything else let us know, for now let's just merge this as-is.