Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/GameConfigWidget: Add Manual Texture Sampling #12068

Merged
merged 3 commits into from Jul 27, 2023

Conversation

SuperSamus
Copy link
Contributor

@SuperSamus SuperSamus commented Jul 24, 2023

Felt the need to add it due to #12059.

A few notes:

  • The option in the GUI will be located under "Core", even though it is a "Video_Hacks"
  • Didn't add a tooltip

In order to not hard code `if (key == "FastDiscSpeed")`
Comment on lines 106 to 108
m_emulate_disc_speed->setToolTip(tr("Enable emulated disc speed. Disabling this can cause crashes "
"and other problems in some games. "
"(ON = Compatible, OFF = Unlocked)"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this now exceeds the line length limit and the linter wants it changed. This would probably the nicest-looking change:

  m_emulate_disc_speed->setToolTip(tr("Enable emulated disc speed. Disabling this can cause "
                                      "crashes and other problems in some games. "
                                      "(ON = Compatible, OFF = Unlocked)"));

(the linter itself doesn't like breaking up strings and makes a different suggestion.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-formatted it.

@MayImilae
Copy link
Contributor

Screenshots please!

Regarding reversing disc speed, I don't really agree with Pokechu that reversing disc speed belongs in this PR. I'm not opposed to the change by any means, but IMO it should be in its own PR. But I suppose it doesn't matter, I certainly won't block this PR for that.

@Pokechu22
Copy link
Contributor

Regarding reversing disc speed, I don't really agree with Pokechu that reversing disc speed belongs in this PR. I'm not opposed to the change by any means, but IMO it should be in its own PR. But I suppose it doesn't matter, I certainly won't block this PR for that.

To clarify, the disc speed button itself is already reversed; the option is labeled "emulate disc speed" but the setting itself is fastdiscspeed. The change I requested was to change the variable for the checkbox from m_enable_fast_disc to m_emulate_disc_speed so that the variable's name matches the check box's label, and thus the logic for the check box to the setting itself is clearer. This isn't a user-visible change (and if it were, then yes, it would be better for that to be in a separate PR).

Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me.

@JosJuice
Copy link
Member

This dialog really could use an overhaul to make the majority of settings available, but no reason not to merge this PR for now.

@JosJuice JosJuice merged commit 8f1b228 into dolphin-emu:master Jul 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants