New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/GameConfigWidget: Add Manual Texture Sampling #12068
Conversation
e75f798
to
2148526
Compare
In order to not hard code `if (key == "FastDiscSpeed")`
2148526
to
378ef4d
Compare
| m_emulate_disc_speed->setToolTip(tr("Enable emulated disc speed. Disabling this can cause crashes " | ||
| "and other problems in some games. " | ||
| "(ON = Compatible, OFF = Unlocked)")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this now exceeds the line length limit and the linter wants it changed. This would probably the nicest-looking change:
m_emulate_disc_speed->setToolTip(tr("Enable emulated disc speed. Disabling this can cause "
"crashes and other problems in some games. "
"(ON = Compatible, OFF = Unlocked)"));(the linter itself doesn't like breaking up strings and makes a different suggestion.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-formatted it.
378ef4d
to
1e5e319
Compare
|
Screenshots please! Regarding reversing disc speed, I don't really agree with Pokechu that reversing disc speed belongs in this PR. I'm not opposed to the change by any means, but IMO it should be in its own PR. But I suppose it doesn't matter, I certainly won't block this PR for that. |
To clarify, the disc speed button itself is already reversed; the option is labeled "emulate disc speed" but the setting itself is fastdiscspeed. The change I requested was to change the variable for the checkbox from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good to me.
|
This dialog really could use an overhaul to make the majority of settings available, but no reason not to merge this PR for now. |
Felt the need to add it due to #12059.
A few notes: