Prevent SD data loss from silent resync failure #12069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jul 26, 2023
riidefi
force-pushed
the
silent-sd-failure
branch
from
75a7a4d
to
ec5d2a4
Compare
Dentomologist
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Tested with a fake sync failure and the message shows up (or not) correctly.
I suspect there's a higher chance than we would like for users to get mixed up on which direction they're supposed to sync, especially since you can't open or use the config window with the panic alert active, but this PR is still an improvement and I'm mostly mentioning the possibility in case someone can think of something to do about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SD resync failure happens from time to time (e.g. if the folder is open in another program), and usually results in data loss due to it being largely invisible to the end-user until reboot. This PR adds a dialog box to notify the user that such an event has happened, and how to fix it before it is too late.