Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoCommon: update NetplayChatUI's chat message to avoid imgui error #12078

Merged
merged 1 commit into from Jul 29, 2023
Merged

VideoCommon: update NetplayChatUI's chat message to avoid imgui error #12078

merged 1 commit into from Jul 29, 2023

Conversation

iwubcode
Copy link
Contributor

After updating imgui in #12065 , looks like I broke the netplay chat window. A user on discord reported the following error:

image

This PR fixes that by using a hidden label for the InputText field.

@iwubcode
VideoCommon: update NetplayChatUI's chat message input to use a hidde…
dca7c67 
…n label. This avoids an error thrown by imgui
Techjar
Techjar approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@Techjar Techjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AdmiralCurtiss AdmiralCurtiss merged commit 163c97e into dolphin-emu:master Jul 29, 2023
11 checks passed
@iwubcode iwubcode deleted the imgui_netplay_fix branch July 29, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techjar Techjar Techjar approved these changes

@MayImilae MayImilae MayImilae approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@iwubcode @Techjar @MayImilae @AdmiralCurtiss