Fix XFB scaling in D3D #1208
Fix XFB scaling in D3D #1208
Conversation
|
@dolphin-emu-bot rebuild |
|
From some testing it seems to work ok here with direct 3d and The Legend of Zelda: Collector's Edition. |
|
Same here, can confirm Collector's Edition NES games are working in D3D now. Will test the others on my main box where I have the rest of my games. |
|
All of the titles fixed by the OpenGL XFB Scaling are fixed here. |
|
@slx7R4GDZM this PR looks good but needs to be rebased. |
|
Github still says that the PR cannot be automatically merged because of unresolved conflicts. |
|
@slx7R4GDZM you might need to fetch from dolphin-emu/dolphin master first so that you are on the latest before rebasing. |
|
Alright, I'll try that in a bit. Never knew the troubles of merge conflicts before, lol. |
|
Once this is rebased, I'm fairly certain it can be merged. Just prodding to make sure you don't need any help! |
| D3D11_BOX box = CD3D11_BOX(0, 0, 0, width, height, 1); | ||
| D3D::context->UpdateSubresource(m_yuyvTexture, 0, &box, yuyvSrc, 2*width, 2*width*height); | ||
| D3D11_BOX box = CD3D11_BOX(0, 0, 0, stride, height, 1); | ||
| D3D::context->UpdateSubresource(m_yuyvTexture, 0, &box, yuyvSrc, 2 * stride, 2 * stride*height); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Well I fixed the whole multiple commit things but it does look like I'll have to update the repository. Unfortunately when I try to fetch the updates it attempts to fetch them from itself and then obviously says that it's up to date. Any tips? |
|
First |
|
@dolphin-emu-bot rebuild |
No known games, not even Wii MMU games like Cars 2 and Toy Story 3, use custom BATs. This makes BAT resolution a waste of time. BAT handling could be optimized significantly, but as long as nothing uses it, it's easier to just disable it. Should significantly improve performance in MMU-heavy games.
MMU: disable BAT resolution
Misc / warning fixes
|
The build failed, can you fix the errors and try again? Do you need any help with interfacing with the buildbots? |
|
Meh, I think I give up. Somebody can take remake this PR if they want. |
|
We can't rebase/fix it up if the fork is gone. Do you still have the code anywhere? NVM. Points down Not good at this github stuff xD |
|
Yep, in the "changes" tab. Let's see if I can turn that into workable diff... |
Fixes issue 7681.