Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JitArm64: Store PC on debug exit #12081

Merged
merged 1 commit into from Sep 10, 2023

Conversation

JosJuice
Copy link
Member

Should fix https://bugs.dolphin-emu.org/issues/13178.

Jit64 doesn't need to do this because it stores PC directly into ppcState instead of first storing it in a register.

Should fix https://bugs.dolphin-emu.org/issues/13178.

Jit64 doesn't need to do this because it stores PC directly into
ppcState instead of first storing it in a register.
@AdmiralCurtiss
Copy link
Contributor

I can't test this and my ARM assembly knowledge is pretty much nonexistent but this seems reasonable.

@AdmiralCurtiss
Copy link
Contributor

In fact, this exact instruction is used here so it's probably correct:

STP(IndexType::Signed, DISPATCHER_PC, DISPATCHER_PC, PPC_REG, PPCSTATE_OFF(pc));

@AdmiralCurtiss AdmiralCurtiss merged commit 1a0f0e7 into dolphin-emu:master Sep 10, 2023
11 checks passed
@JosJuice JosJuice deleted the jitarm64-debug-exit-pc branch September 10, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants