DolphinQt/EnhancementsWidget: Use custom tooltip for Color Correction button. #12114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, the original logic was loosely based off of Qt's own code. It's possible there may be an update there that could make this more visually appealing. |
iwubcode
approved these changes
Aug 16, 2023
mbc07
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Here the tooltip breaks the text and ends more square-ish looking, without the spacing problems. I couldn't get it to show like the screenshot you posted (please ignore the heavily aliased borders, that's a known problem with the tooltips on high DPI screens):
Regardless, this LGTM...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks slightly weird here and I'm not sure why, it seems like our tooltip doesn't handle the bottom spacing correctly when the tooltip is so short?