Added latching buttons (Android) #12119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is something I think will make a bunch of users happy :) I'm planning on adding a system where you can add custom buttons to the touch overlay that you then can map to whatever you want using Dolphin's input binding system. By then using the Didn't find anything in the code that needed commenting on, but let's see if @t895 would also like to review this. |
t895
reviewed
Aug 26, 2023
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.kt
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.kt
Outdated
Show resolved
Hide resolved
|
Please squash the commits into one. |
ThunderousEcho
force-pushed
the
feature/latching-buttons
branch
from
c46ec50
to
5663b45
Compare
|
Sorry, I meant all the commits. |
Added latching buttons, buttons which turn on when you press them and off when you press them again.
ThunderousEcho
force-pushed
the
feature/latching-buttons
branch
from
5663b45
to
ee395bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added latching buttons, buttons which turn on when you press them and off when you press them again.
This is necessary to play games which require you to press more than 2 buttons at once.