Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoCommon: Fix custom shader constants on GLES #12132

Merged
merged 1 commit into from Aug 22, 2023
Merged

VideoCommon: Fix custom shader constants on GLES #12132

merged 1 commit into from Aug 22, 2023

Conversation

JosJuice
Copy link
Member

No description provided.

@JosJuice JosJuice requested a review from iwubcode August 22, 2023 17:38
@Pokechu22
Copy link
Contributor

Out of curiosity, is the extra strictness on signed and unsigned conversions part of GLES, or is there just a specific mobile driver that's strict about it?

@JosJuice
Copy link
Member Author

It's part of GLES.

iwubcode
iwubcode approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jos. I'll make a note of this for any future changes, I was not aware! LGTM.

@JosJuice JosJuice merged commit 260bad7 into dolphin-emu:master Aug 22, 2023
11 checks passed
@JosJuice JosJuice deleted the gles-uint-const branch August 22, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @Pokechu22 @iwubcode