Jit: Don't discard before gather pipe interrupt check #12138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
This looks sensible, though I have neither tested it nor verified whether the CanCauseGatherPipeInterruptCheck() check actually catches all instructions that can write to the gather pipe.
I'm also wondering if the last commit should be a separate PR, just so we have separate dev builds for them in case we need a user to bisect on something related to this.
This bug has been lurking in the code ever since I added the discard functionality. It doesn't seem to be triggered all that often, and on top of that the emitted code only runs conditionally, so I'm not sure if people have been affected by this bug in practice or not.
This adds a check for the bug addressed by the previous commit.
JosJuice
force-pushed
the
jit-gp-check-discard
branch
from
1a81ff7
to
34b0a6e
Compare
|
I've split out the last commit to PR #12178. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been lurking in the code ever since I added the discard functionality. It doesn't seem to be triggered all that often, and on top of that the emitted code only runs conditionally, so I'm not sure if people have been affected by this bug in practice or not.