Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Deinit Graphics Mod Manager explicitly #12158

Merged
merged 1 commit into from Sep 3, 2023

Conversation

noahpistilli
Copy link
Member

g_graphics_mod_manager wasn't shutdown in VideoBackendBase::ShutdownShared causing

libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

on macOS.

The cause of the error was EventHook in GraphicsModManager calling it's deconstructor, by which time the mutex in the static Storage was already destroyed.

@noahpistilli noahpistilli changed the title VideoCommon: Deinit Graphics Mod Manager implicitly VideoCommon: Deinit Graphics Mod Manager explicitly Sep 3, 2023
@JMC47 JMC47 merged commit 6f6eb73 into dolphin-emu:master Sep 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants