Android: Use custom image loader for game covers #12188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Sep 20, 2023
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/CoilUtils.kt
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/CoilUtils.kt
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/CoilUtils.kt
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/CoilUtils.kt
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Sep 20, 2023
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/CoilUtils.kt
Outdated
Show resolved
Hide resolved
This fixes a bug where custom cover loading was initiated but would finish by the time another image view would be in the place of the previous one.
|
If a user adds a game to Dolphin and Dolphin fetches a cover over the network, and then the user adds a custom cover, will Dolphin pick up on the custom cover without the user having to manually clear the cache? |
|
I just tested to be sure - You won't have to clear the cache, Only the activity/fragment needs to be recreated like before. |
JosJuice
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where custom cover loading was initiated but would finish by the time another image view would be in the place of the previous one.
Turns out before I didn't really understand how to use coil for async loads properly. This should feed it everything it needs.