Rename the JIT function Default() to FallBackToInterpreter(). Communicates intent way better in terms of telling the reader what's going on. #122
+1,774
−1,338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not fan of the name, I personally think "FallbackToInterpreter" would be better (verb instead of noun). |
|
Changed it |
…cates intent way better in terms of telling the reader what's going on. Also did some minor cleanup in functions that used Default.
|
LGTM |
1 similar comment
|
LGTM |
|
Post a buildbot-try result and I'll merge this. |
|
Can't run a try, get a string too long error. If the buildbot server config still has the Twisted string limit at 640KB (it's default), I'd consider raising this to like 10 megs or some arbitrary large number of your choosing. 640KB will get blown over easily when throwing diffs around. That, or we could try getting a CI like Travis or whatever up and running since it integrates with Github well and just automatically tests pull requests on the fly as they're made. |
|
Alright, buildbot try succeeded, can be merged. |
Parlane
added a commit
that referenced
this pull request
Mar 5, 2014
Rename the JIT function Default() to FallBackToInterpreter(). Communicates intent way better in terms of telling the reader what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also did some minor cleanup in functions that used Default (though this is almost purely whitespace)