Apply Clang-Tidy's modernize-use-starts-ends-with

[nicovank]

I am currently working on some additions to this Clang-Tidy check, and running it on some C++ codebases to test my changes.

This should be safe as it seems Dolphin requires a C++ standard and/or a compiler version that will always have starts_with included. (In CMakeLists: C++23 for MSVC, GCC 10, Clang 12). Dolphin builds on my setup following changes.

python3 ~/llvm-project/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py \
    -clang-tidy-binary="~/llvm-project/build/bin/clang-tidy" \
    -clang-apply-replacements-binary="~/llvm-project/build/bin/clang-apply-replacements" \
    -checks="-*,modernize-use-starts-ends-with" \
    -header-filter=".*" \
    -fix -format

This improves readability. There's also a theoretical performance improvement replacing find(...) == 0 by compare(...) == 0 or starts_with(...), it's probably negligible.

[BhaaLseN]

Is this fully automated, or did you modify things by hand? We normally put the curlies on the next line, and we use curlies whenever either condition or contents span over multiple lines; which should be enforced by clang-format (see the output of the lint builder)

[nicovank]

This was automated, -format option is supposed to run clang-format after changes. I also noticed that, will re-run manually.

[nicovank]

Should be fixed, not sure why it didn't work in the first place, a second clang-format run did the trick. I'll keep an eye on CI.

[BhaaLseN]

Reads a lot nicer that way, and clearly communicates intent. I like that :)

[nicovank]

Thanks! I have no commit access, please feel free to hit the merge button 👍 .