Change the DebugInterface, PPCDebugInterface, and DSPDebugInterface to use CamelCase function names. #128
+157
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use CamelCase names. This is the standard coding convention in the codebase, so our interfaces should use it too.
|
lgtm, altho i probably have tro break it to you that most commonly "camel case" refers to "lower camel case" (first letter in lower case, which is what it was before). I hate that convention myself (and always assumed pascalCase was that one; with the p stretching downwards, while CamelCase had two humps upwards just like the camel) - but apparently the almighty wikipedia tells me that the correct term here is "PascalCase" or "Upper CamelCase" =/ |
|
LGTM. |
delroth
added a commit
that referenced
this pull request
Mar 3, 2014
…names Change the DebugInterface, PPCDebugInterface, and DSPDebugInterface to use CamelCase function names.
|
@BhaaLseN Noted. Will keep it in mind if I ever make a change like this again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is the standard coding convention in the codebase, so our interfaces should use it too.