Dl cache remove #13
Merged
Dl cache remove #13
+28
−1,066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
| @@ -495,7 +495,6 @@ wxArrayString GetListOfResolutions() | |||
| // - other hacks | |||
| { | |||
| wxGridSizer* const szr_other = new wxGridSizer(2, 5, 5); | |||
| szr_other->Add(CreateCheckBox(page_hacks, _("Cache Display Lists"), wxGetTranslation(dlc_desc), vconfig.bDlistCachingEnable)); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Note that there is still a huge list of games which still set |
|
If/when dlist caching is removed, remember to tag me on issue 7000. There aren't many references to dlist caching on the wiki but it needs to be dealt with. |
This option was known to break every second game and only boost a bit. It also seems to be broken because of streaming into pinned memory and buffer storage buffers. v2: also remove dlc_desc
|
neobrain: done |
|
Great! Btw, please use a more descriptive PR title next time :) |
CarlKenner
referenced
this pull request
in CarlKenner/dolphin
Dec 14, 2014
I fixed the stereoscopic 3D to make it VR
Merged
ghost
mentioned this pull request
rapito
pushed a commit
to rapito/dolphin
that referenced
this pull request
Sep 16, 2022
Update from FaultyPine/master & fix merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As caching display lists is doomed to fail (in fact, tons of games has glitches with this "feature") and as it's completely broken because of issue 7000 on nvidia + amd drivers, this branch will remove it.
On cleaning up the VertexLoader, I've seen that we have some functions which just always call another function. They are removed in the second commit.