Simplify ShowSound() in FileMonitor.cpp. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better: IsSoundFile(const std::string&). |
Now if more sound types are found, they just need to simply be added to the unordered set. - Also changed ShowSound() to IsSoundFile() - Fixed IsSoundFile’s definition in FileMonitor.h. This whole time it has been defined as a void method, when in reality it was a bool function. - Changed the FileMonitor’s string parameters to be constant references.
.adx is used in various games, so this should definitely be here.
|
Should be all good now. |
|
lgtm |
delroth
added a commit
that referenced
this pull request
Mar 4, 2014
Simplify ShowSound() in FileMonitor.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now if more sound types are found, they just need to simply be added to the set.