Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit 1a428de189eb9456695429adc11b606936218924 introduced a bug by usin... #133

Merged
merged 1 commit into from Mar 5, 2014
Merged

commit 1a428de189eb9456695429adc11b606936218924 introduced a bug by usin... #133

merged 1 commit into from Mar 5, 2014

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Mar 5, 2014

...g a signed enum in a bitfield, the value of which is then used in a ldmxcsr instruction. The sign-extension corrupts the value, causing an exception by attempting to load mxcsr with an invalid value.

@Parlane
Copy link
Member

Parlane commented Mar 5, 2014

Your commit message is terrible <_<

{
ROUND_NEAR = 0,
ROUND_CHOP = 1,
ROUND_UP = 2,
ROUND_DOWN = 3
};
enum PrecisionModes {
enum PrecisionModes : u32
{

This comment was marked as off-topic.

… the value of which is then used in a ldmxcsr instruction. The sign-extension corrupts the value, causing an exception by attempting to load mxcsr with an invalid value.
Sonicadvance1 added a commit that referenced this pull request Mar 5, 2014
@Sonicadvance1 Sonicadvance1 merged commit 3d927d5 into dolphin-emu:master Mar 5, 2014
@shuffle2 shuffle2 deleted the fix-ldmxscr-exception branch March 6, 2014 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants