VideoSoftware: remove const memory usage of DebugUtil #135
Conversation
|
So we only alloc this ~50MB when the video software backend is used. |
|
lgtm |
| @@ -245,7 +253,7 @@ void OnObjectEnd() | |||
| swstats.thisFrame.numDrawnObjects, ObjectBufferName[i], i - BufferBase[i]); | |||
|
|
|||
| (void)TextureToPng((u8*)ObjectBuffer[i], EFB_WIDTH * 4, filename, EFB_WIDTH, EFB_HEIGHT, true); | |||
| memset(ObjectBuffer[i], 0, sizeof(ObjectBuffer[i])); | |||
| memset(ObjectBuffer[i], 0, EFB_WIDTH*EFB_HEIGHT*sizeof(u32)); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I kinda have a de-ja-vu now...didn't we have something like this already once? |
|
|
||
| void Init() | ||
| { | ||
| for (int i = 0; i < NumObjectBuffers; i++) | ||
| { | ||
| memset(ObjectBuffer[i], 0, sizeof(ObjectBuffer[i])); | ||
| ObjectBuffer[i] = new u32[EFB_WIDTH*EFB_HEIGHT](); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@dolphin-emu-bot rebuild (Just to have an up-to-date status on PRs that are mergeable - sorry for the spam) |
|
LGTM |
| { | ||
| for (int i = 0; i < NumObjectBuffers; i++) | ||
| { | ||
| delete [] ObjectBuffer[i]; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM once the spacing issues are resolved. I don't think we should block this because of the make_unique discussion from above, particularly since there has been no consensus on whether we want to make that a coding style rule or not. |
|
@neobrain Yea the make_unique stuff shouldn't matter for this. As said, that can be converted all at once if/when we ever decide that. |
|
spaces are fixed |
VideoSoftware: Remove const memory usage of DebugUtil
No description provided.