Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OGL: remove ubo workaround #14

Merged
merged 1 commit into from Feb 4, 2014
Merged

OGL: remove ubo workaround #14

merged 1 commit into from Feb 4, 2014

Conversation

degasus
Copy link
Member

@degasus degasus commented Jan 30, 2014

This was only keeped for some broken mesa versions. Meanwhile most used versions should be fixed for almost a year.

@degasus
Copy link
Member Author

degasus commented Jan 30, 2014

Please don't accept this one until HdkR confirm it.

neobrain
neobrain reviewed Jan 30, 2014
View reviewed changes
Source/Core/VideoBackends/OGL/Render.cpp
@@ -521,14 +529,6 @@ void InitDriverInfo()
if(g_ogl_config.max_samples < 1)
g_ogl_config.max_samples = 1;

if(g_Config.backend_info.bSupportsGLSLUBO && DriverDetails::HasBug(DriverDetails::BUG_BROKENUBO))

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@neobrain
Copy link
Member

Apart from my other comment, looks good to me.

@neobrain
Copy link
Member

By the way, CC @Sonicadvance1 .

@ghost ghost assigned Sonicadvance1 Jan 31, 2014
@degasus
OGL: remove ubo workaround
6089e44 
This was only keeped for some broken mesa versions. Meanwhile most used versions should be fixed for almost a year.
@degasus
Copy link
Member Author

degasus commented Feb 1, 2014

neobrain: updated

degasus
degasus reviewed Feb 2, 2014
View reviewed changes
Source/Core/VideoBackends/OGL/Render.cpp
"GPU: Does your video card support OpenGL 3.1?");
bSuccess = false;
}
else if (DriverDetails::HasBug(DriverDetails::BUG_BROKENUBO))

This comment was marked as off-topic.

Sign in to view

@Sonicadvance1
Copy link
Contributor

Only problem I see with this is v46 qualcomm drivers just straight up sigsegv with using our UBOs.
The v46 drivers are widely used on Snapdragon 800 devices since the v4X drivers were the first to support the hardware correctly.
I don't have a v46 device to test with since I was using someone else's phone at the time to test it last time.

I only did some light testing with it last time, since it seems it is due to how large our UBOs are, I tested a UBO with only a couple array members and it worked, but I couldn't test it too much.

@neobrain
Copy link
Member

neobrain commented Feb 4, 2014

Is this something we care about?

The non-UBO code path is basically blocking the merging of tev_fixes_new, unless we want to make that code path even more complicated by supporting integer constants ...

@neobrain neobrain closed this Feb 4, 2014
@neobrain neobrain reopened this Feb 4, 2014
@neobrain
Copy link
Member

neobrain commented Feb 4, 2014 

23:00 <HdkR> neobrain: I have said multiple times that I don't want Android related issues blocking desktop development
23:01 <HdkR> neobrain: I say merge it if it is blocking tev_fixes
23:02 <HdkR> I refuse to let Qualcomm block improvements

Sounds reasonable.

neobrain added a commit that referenced this pull request Feb 4, 2014
@neobrain
Merge pull request #14 from degasus/uboWorkaroundRemove
af24ed7 
OGL: Remove non-UBO code path.
@neobrain neobrain merged commit af24ed7 into dolphin-emu:master Feb 4, 2014
@degasus degasus deleted the uboWorkaroundRemove branch February 4, 2014 22:06
@degasus degasus mentioned this pull request Nov 14, 2015
Merged
@tokumeiwokiboushimasu tokumeiwokiboushimasu mentioned this pull request Jun 12, 2020
Merged
@ghost ghost mentioned this pull request Feb 11, 2021
Merged
Techjar pushed a commit to Techjar/dolphin that referenced this pull request Jan 30, 2022
@SirMangler
Merge pull request dolphin-emu#14 from SlawekNowy/master
6e74a59 
Small compilation hiccup
rapito pushed a commit to rapito/dolphin that referenced this pull request Sep 16, 2022
@JaredWhiteOne
Merge pull request dolphin-emu#14 from FaultyPine/temp-merge
9972c46 
fix ExiStructures.h include & update submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sonicadvance1 Sonicadvance1

Labels
None yet
Milestone
No milestone
3 participants
@degasus @neobrain @Sonicadvance1