Implement workaround for Windows versions which do not support XSAVE. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #if defined(_WIN32) && defined(_ARCH_64) | ||
|
|
||
| // This puts the rest of this translation unit into a segment which is |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM :) |
|
Indent with tabs, not spaces. Please explictly #include required files. Other than that, LGTM. |
|
re: #includes: I can see including math.h here, but do you really want to be including windows.h all over the place? |
|
We don't use functions from windows.h all over the place. In the files that do, yes, I'd prefer having an explicit #include to make it more clear where some functions come from. |
|
(also, ) |
|
|
Fixes CRT math routines using FMA instructions from causing illegal instructions.
delroth
added a commit
that referenced
this pull request
Mar 6, 2014
Implement workaround for Windows versions which do not support XSAVE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes CRT math routines using FMA instructions from causing illegal instructions.