Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run clang-modernize and manually fix the result #142

Merged
merged 3 commits into from Mar 9, 2014
Merged

Run clang-modernize and manually fix the result #142

merged 3 commits into from Mar 9, 2014

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Mar 8, 2014

clang-modernize makes C++ code use some new C++11 features.

  • I avoided the use-auto transform because it makes the code way too non-obvious.
  • I'm not sure about the pass-by-value transform.
  • We don't use std::auto_ptr.

@Parlane
Copy link
Member

Parlane commented Mar 8, 2014

LGTM

@Tilka
Copy link
Member Author

Tilka commented Mar 8, 2014

(only FifoDataFile.cpp changed after @Parlane's comment)

@Parlane
Copy link
Member

Parlane commented Mar 8, 2014

LGTM

@lioncash
Copy link
Member

lioncash commented Mar 8, 2014

Looks good to me.

@Tilka
clang-modernize -loop-convert
c89f04a 
and some manual adjustments
@Tilka
clang-modernize -add-override
f28116b
@Tilka
clang-modernize -use-nullptr
d802d39 
and s/\bNULL\b/nullptr/g for *.cpp/h/mm files not compiled on my machine
Parlane added a commit that referenced this pull request Mar 9, 2014
@Parlane
Merge pull request #142 from Tilka/clang-modernize
633dc75 
Run clang-modernize and manually fix the result
@Parlane Parlane merged commit 633dc75 into dolphin-emu:master Mar 9, 2014
@Tilka Tilka deleted the clang-modernize branch March 9, 2014 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Tilka @Parlane @lioncash