Rename assemble.cpp/.h and disassemble.cpp./.h #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and DSPDisassembler.cpp/.h
|
LGTM, but why do we have DSP at the start of filenames if it's already in the directory names? |
|
That's a good point. However I just renamed them like that to maintain consistency. (JIT and PPC stuff do that too) |
|
Provide a try build and I'll merge this. |
|
Buildbot try is successful. |
delroth
added a commit
that referenced
this pull request
Mar 9, 2014
Rename assemble.cpp/.h and disassemble.cpp./.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now DSPAssembler.cpp/.h and DSPDisassembler.cpp/.h