JIT: add 64-bit write support to FIFO functions and fix immediates #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FioraAeterna
force-pushed
the
fifo64
branch
3 times, most recently
from
ca9716b
to
c74b31c
Compare
|
The Last Story pops up an error of "WriteNormalOp - Unhandled case" |
| @@ -210,7 +210,7 @@ void XEmitter::MOVTwo(int bits, Gen::X64Reg dst1, Gen::X64Reg src1, Gen::X64Reg | |||
| void XEmitter::ABI_CallFunctionAC(const void *func, const Gen::OpArg &arg1, u32 param2) | |||
| { | |||
| if (!arg1.IsSimpleReg(ABI_PARAM1)) | |||
| MOV(32, R(ABI_PARAM1), arg1); | |||
| MOV(64, R(ABI_PARAM1), arg1); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Also fix 64-bit values passed to CallAC and otherwise correct immediate handling in FIFO writes. Fixes 007 Nightfire.
|
@FioraAeterna What issue are you referring to exactly? About 007: Nightfire, that is. Edit: Ah, thanks :P |
|
I broke it in my latest FIFO-related commit ^^; the loading screen looks wrong. |
FioraAeterna
changed the title
skidau
added a commit
that referenced
this pull request
Nov 12, 2014
JIT: add 64-bit write support to FIFO functions and fix immediates
|
I played Nightfire recently. I noticed nothing wrong. But it's good to know it's fixed again! :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes 007 Nightfire.