Fix an unused variable within function GetScheduledEventsSummary() in CoreTiming.cpp #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
looks fine |
delroth
added a commit
that referenced
this pull request
Jan 30, 2014
Fix an unused variable within function GetScheduledEventsSummary() in CoreTiming.cpp
Helios747
pushed a commit
that referenced
this pull request
May 11, 2018
OrN
pushed a commit
to OrN/dolphin
that referenced
this pull request
May 12, 2018
JosJuice
pushed a commit
to JosJuice/dolphin
that referenced
this pull request
Jul 17, 2020
…ad function to actually pull proper files from filesystem of iso volume
ghost
mentioned this pull request
rapito
pushed a commit
to rapito/dolphin
that referenced
this pull request
Sep 16, 2022
…integration Exi structures integration
Gaberboo
pushed a commit
to Gaberboo/dolphin
that referenced
this pull request
May 3, 2023
* A handful of improvements to make the stubs complete, more usable and follow up-to-date stub typing standards (https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#conventions): - Explicitly re-export imports meant to be re-exported - Fixed how modules are exposed because `dolphin` is not a package - Now passes AutoPep8 (at 100 line-length, aggressive level 3), Mypy, Pyright, Flake8-PYI, add-trailing-comma and a subset of pydocstyle - Single-line docstrings on a single line - Consistently separate docstring description from docstring references - Explicitly return `None`. Otherwise Mypy infers as `Any` and Pyright as `Unknown` - Mark type-only classes with `type_check_only`. Those classes are type references and cannot be imported at runtime. - Prefer `|` rather than `Union` or `Optional` - Prefer `collections.abc.Callable` over `typing.Callable` - Fixed the syntax error in tuple return types - Explicitly type `Position` as a `TypeAlias` - Fixed the type of optional parameters that have a default value of `None`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.