Kill off some usages of c_str. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| std::string TMessage = StringFromFormat("%s | ", scm_rev_str) + | ||
| SMessage; | ||
| std::string SMessage = StringFromFormat("%s | %s", SSettings.c_str(), SFPS.c_str()); | ||
| std::string TMessage = StringFromFormat("%s | ", scm_rev_str) + SMessage; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Also changes some function params, but this is ok. Some simplifications were also able to be made (ie. killing off strcmps with ==, etc).
|
LGTM |
delroth
added a commit
that referenced
this pull request
Mar 14, 2014
Kill off some usages of c_str.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also changes some function params, but this is ok.
Some simplifications were also able to be made (ie. killing off strcmps with ==, etc).
Please point out anything wrong found :)