Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryInterface: properly register region MMIOs. #165

Merged
merged 1 commit into from Mar 14, 2014

Conversation

delroth
Copy link
Member

@delroth delroth commented Mar 14, 2014

No description provided.

@Parlane
Copy link
Member

Parlane commented Mar 14, 2014

Does the loop variable need to be an int here?

@delroth
Copy link
Member Author

delroth commented Mar 14, 2014

Well, what do you want it to be?

@Parlane
Copy link
Member

Parlane commented Mar 14, 2014

Appropriate one of these: unsigned int, u32, u64, u16, u8 ?

@delroth
Copy link
Member Author

delroth commented Mar 14, 2014

I guess it could be a u32 if you wanted it, but "int" is the default type I use when I don't care.

@Tilka
Copy link
Member

Tilka commented Mar 14, 2014

@Parlane: It's generally a good idea to use signed integers when you can make sure the value will not overflow. It enables the compiler to do some interesting optimizations.

@Parlane
Copy link
Member

Parlane commented Mar 14, 2014

Alright, LGTM

Parlane added a commit that referenced this pull request Mar 14, 2014
MemoryInterface: properly register region MMIOs.
@Parlane Parlane merged commit 76e3a74 into dolphin-emu:master Mar 14, 2014
@SizzlingCalamari
Copy link
Contributor

@Tilka
It's a coincidence that I had just learned that tip a few days ago, although it can be quite annoying to avoid the signed/unsigned comparison compile warnings when looping with indices on STL containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants