Fix the Android build's configuration setting/getting #166
+38
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -314,7 +314,7 @@ JNIEXPORT jstring JNICALL Java_org_dolphinemu_dolphinemu_NativeLibrary_GetConfig | |||
| ini.Load(File::GetUserPath(D_CONFIG_IDX) + std::string(File)); | |||
| std::string value; | |||
|
|
|||
| ini.Get(Key, Value, &value, Default); | |||
| ini.Get(std::string(Key), std::string(Value), &value, std::string(Default)); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…droid build which relied on that. Convert our C-strings to std::strings before using
delroth
added a commit
that referenced
this pull request
Mar 15, 2014
Fix the Android build's configuration setting/getting
Joern-P
pushed a commit
to Joern-P/dolphin
that referenced
this pull request
Mar 16, 2023
* Add L/R Analog Input options for GCPads. * Various input fixes. - Add L3/R3 as alias for soft shoulder presses. - Allow more range when analog triggers are used for GC Controllers. - Enable GC Controller input in ports 5-8 in Wii mode. - Fix sideways Wiimote input expressions. - Fix tilt orientation in sideways wiimotes. - Add tilt controls to Wiimote + Nunchuck. - Alias ports 5-8 and 1-4 in Wii mode. * Changes based on PR feedback: - Disable port 1-4 and 5-8 aliasing for GC Controllers. - Default to Wii mode in ports 1-4. * PR Review Fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Due to the removal of our char* IniFile setters/getters this broke Android build which relied on that.
Convert our C-strings to std::strings before using