Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save bHLE_BS2 to config cache before it can be changed while booting. #170

Merged
merged 1 commit into from Mar 17, 2014
Merged

Save bHLE_BS2 to config cache before it can be changed while booting. #170

merged 1 commit into from Mar 17, 2014

Conversation

RachelBryk
Copy link
Member

This variable can be changed in SConfig::AutoSetup, so we need to save it before that is called.

@delroth
Copy link
Member

delroth commented Mar 16, 2014

  1. Why does this get changed? In which case?
  2. Add a comment in the code explaining why this initialization is not grouped with the others.

@RachelBryk
Copy link
Member Author

  1. It's set to false for all wii games, or if the bios image isn't found.
  2. Okay.

@RachelBryk
Save bHLE_BS2 to config cache before it can be changed while booting.
89dbec4 
This variable can be changed in SConfig::AutoSetup, so we need to save it before that is called.
delroth added a commit that referenced this pull request Mar 17, 2014
@delroth
Merge pull request #170 from RachelBryk/save-skip-bios
4a906fd 
Save bHLE_BS2 to config cache before it can be changed while booting.
@delroth delroth merged commit 4a906fd into dolphin-emu:master Mar 17, 2014
@RachelBryk RachelBryk deleted the save-skip-bios branch July 6, 2014 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@RachelBryk @delroth