File tree building cleanup #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed parentheses from the returns. - Put the function declaration headers back on a single line. - Make FindFileInfo's parameter a const string reference.
| @@ -201,20 +201,13 @@ u32 CWII_IPC_HLE_Device_di::ExecuteCommand(u32 _BufferIn, u32 _BufferInSize, u32 | |||
| // Don't do anything if the log is unselected | |||
| if (LogManager::GetInstance()->IsEnabled(LogTypes::FILEMON)) | |||
| { | |||
| const char *pFilename = nullptr; | |||
| std::string filename; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@lioncash build fails, please fix. |
|
@delroth All good now. |
| } | ||
|
|
||
| const SFileInfo* pFileInfo = FindFileInfo(_rFullPath); | ||
|
|
||
| if (pFileInfo != nullptr) | ||
| { | ||
| return((size_t) pFileInfo->m_FileSize); | ||
| return (size_t) pFileInfo->m_FileSize; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Haven't tested, but other than that one comment, LGTM. |
Technically this also simplifies on disc filename building in general.
Sonicadvance1
added a commit
that referenced
this pull request
Mar 23, 2014
File tree building cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Does a light cleanup to the functions involved in building the file tree for the file viewer.