Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra parameters field from the PH. #172

Merged
merged 1 commit into from Mar 15, 2014
Merged

Remove the extra parameters field from the PH. #172

merged 1 commit into from Mar 15, 2014

Conversation

Linktothepast
Copy link
Contributor

Metroid: Other M was the only game which required this field, but the
issue in that game can be fixed properly by enabling format change
emulation. Hence, there's no point in having this around anymore.
Fixes issue 6644.

@delroth
Copy link
Member

delroth commented Mar 15, 2014

LGTM.

@neobrain
Copy link
Member

You'll also want to change:

  • VideoCommon/VideoConfig.cpp: CHECK_SETTING("Video", "PH_ExtraParam", iPhackvalue[3]);

  • VideoCommon/VideoConfig.h int iPhackvalue[4] => iPhackvalue[3]

  • VideoCommon/VertexShaderManager.cpp: Remove all of these:

    static bool g_ProjHack3;
    ....
    bool bProjHack3 = false;
    ...
    
    sTemp[0] = "DISABLED";
    bProjHack3 = (iPhackvalue[3] == 1) ? true : bProjHack3;
    if (bProjHack3)
        sTemp[0] = "ENABLED";
    NOTICE_LOG(VIDEO, "- Extra Parameter: %s", sTemp[0]);
    ...
    g_ProjHack3 = bProjHack3;
    ...
    g_fProjectionMatrix[15] = (g_ProjHack3 && rawProjection[0] == 2.0f ? 0.0f : 1.0f);  //causes either the efb copy or bloom layer not to show if proj hack enabled
    

The last line can be changed to g_fProjectionMatrix[15] = 1.0f;.

@Linktothepast
Copy link
Contributor Author

@neobrain OK, done + remove a comment that is no longer necessary.

@neobrain
Copy link
Member

Alright, now the two commits just need to be squashed and it's good to go :)

Metroid: Other M was the only game which required this field, but the
issue in that game can be fixed properly by enabling format change
emulation. Hence, there's no point in having this around anymore.
Fixes issue 6644.
delroth added a commit that referenced this pull request Mar 15, 2014
Remove the extra parameters field from the PH.
@delroth delroth merged commit 880bbe1 into dolphin-emu:master Mar 15, 2014
@Linktothepast Linktothepast deleted the extra_parameter branch March 15, 2014 15:54
Joern-P pushed a commit to Joern-P/dolphin that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants