Accurate loading times for Wii games #1739
Conversation
The reply delay of a command shouldn't be ignored just because the previous command isn't done yet. DI is way too fast without this change.
JosJuice
force-pushed
the
wii-di-timing
branch
from
73e9d91
to
34a37cc
Compare
| // Ensure replies happen in order | ||
| const s64 ticks_until_last_reply = last_reply_time - CoreTiming::GetTicks(); | ||
| if (ticks_until_last_reply > 0) | ||
| result.reply_delay_ticks += ticks_until_last_reply; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
SSBB (arbitrarily picked game) confirmed working by me and NSMBWii (mentioned in the removed old comments) confirmed working by JMC. The DKCR problems mentioned in the old comments are probably caused by the old AX HLE. Are there any games that are known to have problems with DI timing, other than the ones mentioned in the comments? If not, I don't think there are many specific games we can test. |
|
Someone should double-check that this doesn't cause any regressions with four Wiimotes connected... other than that, I don't have any suggestions for testing. |
|
Do they have to be real Wiimotes, or are emulated ones fine? |
|
Preferably at least one real Wiimote. |
|
Used 3 real wiimotes via DolphinBar and one emulated wiimote to attempt to play through stage 1-1 of NSMBWii. I failed, but the PR didn't have any ill-effects that I could tell. |
Accurate loading times for Wii games
This is a continuation of PR 1634. WII_IPC_HLE_Device_DI now uses all the timing accuracy improvements that DVDInterface has gotten throughout this year. Also, the fast disc speed option now works for Wii games. The second and third commits might cause problems in games that rely on specific IPC timings, so testing is needed.