Remove an unnecessary wx translation underscore macro from PHackSettings. #179
Conversation
…ngs. Also removed an unnecessary string -> wx string conversion.
|
Uhh.. wait, is it actually all that unnecessary? I was thinking this was an actual ini value when I said it was redundant on IRC, but now that I look at the context it does seem okay, unless I'm missing something. |
|
+1. OTOH, I'm not sure why we allow editing PHacks via the GUI. Or why we have PHacks at all, but that's another problem. |
Remove an unnecessary wx translation underscore macro from PHackSettings.
|
Why was this merged? Can you confirm that translation was redundant? This is not a value that's going in an INI file, and nobody LGTM'd the change. |
|
What is the difference between +1 and LGTM ? |
|
The difference is that +1 is ambiguous when replying to a comment. I was +1-ing @neobrain's comment. |
|
Interesting, looked unrelated to neobrains. |
|
mmmm. I misread your comment. |
|
You shouldn't merge things in the first place just because @delroth says "+1" when I already (effectively) said "-1". Instead, should have waited for a reply from @lioncash to clear up remaining discussions which cover critical criteria for merging. So.. yeah, it was pretty much irrelevant what @delroth was referring to. |
|
Yeah, after further looking, this shouldn't have been merged, as that was the text shown for when the user want to specify a custom projection hack (although it should have plainly been "Custom"). However, in the discussion and sometimes in the IRC, it's said that the Projection Hack UI shouldn't even exist. Do you want me to remove the UI in its entirety, or just leave it as is? |
|
I think it would make sense to remove this UI. The end goal is to have PHacks completely go away. Where they are used as enhancements, they should be replaced with cheat codes. Where they are used to work around bugs, the bugs should be fixed. /me hates PHacks since they actually caused issues in the past, in SoAL for example. |
Update Valid File Extensions
Also removed an unnecessary string -> wx string conversion.