Move two macros (JITDISABLE and INSTRUCTION_START) into JitBase.h. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (JITDISABLE and INSTRUCTION_START) and simply have it in the JitBase.h source file. This way the macro is just located in one spot rather than 6 places.
|
@Sonicadvance1 Can I get your input on this? |
|
LGTM |
|
+1 (LGTM? Lets Get it To Master?) |
|
Looks Good To Me. On Fri, Jan 31, 2014 at 8:10 PM, BhaaL notifications@github.com wrote:
Pierre "delroth" Bourdon delroth@gmail.com |
|
LGTM |
delroth
added a commit
that referenced
this pull request
Feb 1, 2014
Move two macros (JITDISABLE and INSTRUCTION_START) into JitBase.h.
CarlKenner
referenced
this pull request
in CarlKenner/dolphin
Dec 19, 2014
Another difficult merge done.
ghost
mentioned this pull request
rapito
pushed a commit
to rapito/dolphin
that referenced
this pull request
Sep 16, 2022
…res-implementation Replays structures implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reduces 'copypasta' of macros across JIT platforms.
Keeps it nice and centralized on one macro set.