Shader cleanup #185
Merged
Shader cleanup #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,16 +219,24 @@ static inline void GeneratePixelShader(T& out, DSTALPHA_MODE dstAlphaMode, API_T | |||
| "\treturn tmp.x + tmp.y + tmp.z + tmp.w;\n" | |||
| "}\n\n"); | |||
|
|
|||
| // rounding + method convertion | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@dolphin-emu-bot rebuild |
|
I've droped the constant usage patch and so also the hand placed register removal. But no other change here in this PR was based on this change, so this should be safe. |
| "\tfloat4 " I_NORMALMATRICES"[32];\n" | ||
| "\tfloat4 " I_POSTTRANSFORMMATRICES"[64];\n" | ||
| "\tfloat4 " I_DEPTHPARAMS";\n" | ||
| "};\n"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM once the cosmetic issues are sorted out. |
|
Is this good now? Because it LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This branch mostly try to extract common used function out of the shader gen and some cleanups.
@neobrain: if you don't like my changes about profilation which constants are used, I'll drop it out of this list.