Some cleanups for OGL/Vertexmanager.cpp #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -166,8 +158,7 @@ void VertexManager::vFlush(bool useDstAlpha) | |||
| ProgramShaderCache::UploadConstants(); | |||
|
|
|||
| // setup the pointers | |||
| if (g_nativeVertexFmt) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Please put "OGL/VertexManager: " in front of the commit messages so that people glancing over the commit log know what's going on without having to lookup the full patch changes. |
|
I could add an in the beginning but considering how long this has worked I guess it never becomes zero. |
neobrain
added a commit
that referenced
this pull request
Mar 18, 2014
Some cleanups for OGL/Vertexmanager.cpp
|
By the way, please use a more sensible branch name in the future, since the branch name appears in the merge commit message and I can't change it upon merging. |
The variable is already dereferenced both before and after this check which means that if this variable would ever be zero it would have crashed dolphin already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Although it is always scary to modify behavior around global variables I think 46b7cfe should be safe.